On Wed, 24 Sep 2025 20:05:34 GMT, Chen Liang <[email protected]> wrote:
>> Oracle copyright is added when we make changes to the upstream source. In >> this case, I replaced the newly introduced reference to Apache Commons Lang >> with a Utils method, thus the copyright year 2025 since we haven't made >> changes to the upstream source until now. Also added is the LastModified tag >> as required by the license. Note the tag was not there until now. > > If Apache's bcel constantly introduce new dependencies, monkey patches like > these are no better than migrating the whole xsltc to use ClassFile API for > bytecode generation, in my opinion. Migrating off of BCEL would certainly be great. If you have the time and interest, you're more than welcome to explore it further. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/27459#discussion_r2379632322
