On Wed, 24 Sep 2025 17:41:25 GMT, Naoto Sato <[email protected]> wrote:
>> Update Commons BCEL to Version 6.10.0.
>>
>> Test: T1-3 passed
>
> src/java.xml/share/classes/com/sun/org/apache/bcel/internal/classfile/AnnotationEntry.java
> line 2:
>
>> 1: /*
>> 2: * Copyright (c) 2025, Oracle and/or its affiliates. All rights reserved.
>
> IANAL, but I think the original year needs to be here, as apparently it has
> been in the repository.
>
> Also, I see other files, e.g., `ArrayElementValue.java` has the same header
> ("reserved comment block"). Should they also have Oracle copyright?
Oracle copyright is added when we make changes to the upstream source. In this
case, I replaced the newly introduced reference to Apache Commons Lang with a
Utils method, thus the copyright year 2025 since we haven't made changes to the
upstream source until now. Also added is the LastModified tag as required by
the license. Note the tag was not there until now.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27459#discussion_r2376635962
