On Thu, 11 Sep 2025 08:35:05 GMT, Paul Hübner <phub...@openjdk.org> wrote:

> Hi all,
> 
> `FilteredJavaFieldStream` purely exists to hide the field `constantPoolOop` 
> in `jdk.internal.reflect.ConstantPool`. This PR:
> 1) refactors `constantPoolOop` to be a hidden VM injected field `vmholder` 
> (name to be consistent with other similar cases),
> 2) removes `FilteredJavaFieldStream` entirely, and
> 3) updates code previously relying on `FilteredJavaFieldStream` to use 
> `JavaFieldStream` instead.
> 
> Testing: Oracle tiers 1-3.

This looks great.  You said vmtarget but you meant vmholder, which is the right 
name for this internal field since it points to the mirror (instance of 
java.lang.Class).

-------------

Marked as reviewed by coleenp (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/27209#pullrequestreview-3224893210

Reply via email to