On Thu, 24 Jul 2025 17:04:52 GMT, Daniel Jeliński <djelin...@openjdk.org> wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 550 commits: >> >> - merge latest changes from master branch >> - http3: fix new HttpHeadersBuilder constructor >> - qpack - optimize processing of decoder instruction exceptions >> - http3/quic: update the code to use the newly introduced >> jdk.internal.net.http.Origin >> - Avoid speculating about the future in TODOs >> - http3: rename PacketSpaceManager::isAcknowledging to >> PacketSpaceManager::trackAcknowledgement >> - merge latest changes from master branch >> - http3: fix typo in UniStreamPair.java >> - WriterQueue may leak before the constructor completes >> - Limit the number of retries in H3UserInfoTest >> - ... and 540 more: https://git.openjdk.org/jdk/compare/7b255b8a...f0a4fd3d > > test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/http2/Http2RedirectHandler.java > line 61: > >> 59: } >> 60: >> 61: protected byte[] getResponseBytes() { > > this method doesn't appear to be overridden anywhere. Should we revert these > changes? I have logged a task to revisit http2/RedirectTest to use HttpServerAdapters, like http3/H3RedirectTest does. Once this is done we should be able to delete this class - it has an almost duplicate in HttpServerAdapters. https://bugs.openjdk.org/browse/JDK-8365795 ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24751#discussion_r2285442041
