On Thu, 24 Jul 2025 16:02:44 GMT, Daniel Jeliński <djelin...@openjdk.org> wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 550 commits: >> >> - merge latest changes from master branch >> - http3: fix new HttpHeadersBuilder constructor >> - qpack - optimize processing of decoder instruction exceptions >> - http3/quic: update the code to use the newly introduced >> jdk.internal.net.http.Origin >> - Avoid speculating about the future in TODOs >> - http3: rename PacketSpaceManager::isAcknowledging to >> PacketSpaceManager::trackAcknowledgement >> - merge latest changes from master branch >> - http3: fix typo in UniStreamPair.java >> - WriterQueue may leak before the constructor completes >> - Limit the number of retries in H3UserInfoTest >> - ... and 540 more: https://git.openjdk.org/jdk/compare/7b255b8a...f0a4fd3d > > test/jdk/java/net/httpclient/http3/H3StreamLimitReachedTest.java line 94: > >> 92: import static org.testng.Assert.assertFalse; >> 93: >> 94: public class H3StreamLimitReachedTest implements HttpServerAdapters { > > This test seems to duplicate the checks in `StreamLimitTest`. Actually it doesn't. Though they might overlap to some extent. The StreamLimitTest test tests the vanilla retry of requests when stream limit is reached. The H3StreamLimitReachedTest tests more complex scenarios for connection reuse (or not reuse) by issuing different requests with different discovery modes, and mixing that with retries caused by stream limit reached. Maybe the issue here is finding a better name (or better summary) for these tests. I logged https://bugs.openjdk.org/browse/JDK-8365794 ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24751#discussion_r2285373543
