On Wed, 16 Jul 2025 14:30:44 GMT, Alexey Semenyuk <asemen...@openjdk.org> wrote:
>> Alexander Matveev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8351073: [macos] jpackage produces invalid Java runtime DMG bundles [v4]
>
> src/jdk.jpackage/share/classes/jdk/jpackage/internal/model/Package.java line
> 158:
>
>> 156: * package
>> 157: */
>> 158: Optional<Path> predefinedAppOrRuntimeImage();
>
> Let's keep the name unchanged. It fits both application and runtime
> packaging. If it were `predefinedApplicationImage()`, I would suggest
> changing it to `predefinedAppImage()` anyway :).
>
> Let's just update the javadoc:
>
> /**
> * Gets the path to a directory with the predefined app image of this
> package if
> * available or an empty {@link Optional} instance otherwise.
> * <p>
> * If {@link #isRuntimeInstaller()} returns {@code true}, the method
> returns the
> * path to a directory with the predefined runtime. The layout of this
> directory
> * should be of {@link RuntimeLayout} type.
> * <p>
> * If {@link #isRuntimeInstaller()} returns {@code false}, the method
> returns
> * the path to a directory with the predefined application image. The
> layout of
> * this directory should be of {@link ApplicationLayout} type.
> *
> * @return the path to a directory with the application app image of this
> * package
> */
Comment added and function renamed back.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26173#discussion_r2211719421
