On Wed, 16 Jul 2025 15:03:05 GMT, Alexey Semenyuk <asemen...@openjdk.org> wrote:

>> Alexander Matveev has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   8351073: [macos] jpackage produces invalid Java runtime DMG bundles [v3]
>
> src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacPackagingPipeline.java
>  line 316:
> 
>> 314:         String category = isRuntimeBundle ?
>> 315:             "resource.runtime-bundle-info-plist" : 
>> "resource.runtime-info-plist";
>> 316: 
> 
> Changes to the `sign()` method look redundant to me. There are no functional 
> changes, just reformatting and replacing `app` with `env.app()`.

sign() changes reverted.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26173#discussion_r2211719037

Reply via email to