On Wed, 16 Jul 2025 14:20:47 GMT, Alexey Semenyuk <asemen...@openjdk.org> wrote:
>> Alexander Matveev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8351073: [macos] jpackage produces invalid Java runtime DMG bundles [v4] > > test/jdk/tools/jpackage/junit/share/jdk.jpackage/jdk/jpackage/internal/AppImageFileTest.java > line 120: > >> 118: >> 119: final var app = new Application.Stub(null, null, version, >> null, null, >> 120: Optional.empty(), Optional.empty(), List.of(), >> null, Optional.empty(), > > Why is this change? The `Application` interface has not changed. How does it > compile? Am I missing something? It did not compiled when I added `runtimeImageDir` to `Application` interface. It was removed in v4, so I reverted this change in v5. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26173#discussion_r2211640221
