On Tue, 24 Jun 2025 10:05:36 GMT, David Holmes <[email protected]> wrote:
>> Anton Artemov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8359437: Addressed reviewer's comments.
>
> test/hotspot/jtreg/runtime/Monitor/ConcurrentDeflation.java line 79:
>
>> 77: }
>> 78:
>> 79: static private void createMonitors() throws InterruptedException {
>
> I would have put the try/catch around the wait to minimise the number of
> changes.
Makes sense! Addressed in the latest commit.
> test/hotspot/jtreg/runtime/Monitor/ConcurrentDeflation.java line 86:
>
>> 84: monitors[index] = new Object();
>> 85: synchronized (monitors[index]) {
>> 86: monitors[index].wait(1);
>
> Suggestion:
>
> // Force inflation
> monitors[index].wait(1);
Addressed in the latest commit.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25847#discussion_r2163681754
PR Review Comment: https://git.openjdk.org/jdk/pull/25847#discussion_r2163681481
