On Tue, 24 Jun 2025 09:59:50 GMT, Anton Artemov <[email protected]> wrote:
>> This PR contains changes for the 1st phase of the `LockingMode` flag
>> obsoletion.
>>
>> The work is done by @fbredber, I have taken it over and am finishing it
>> while he's on vacation.
>>
>> In the 1st phase one keeps the `LockingMode` variable in all places, but
>> makes it non-settable from the command line. All the C1 and C2 code related
>> to legacy locking will still be in place (but as dead code) and removed
>> later (phase 2).
>>
>> Lightweight locking is the default locking from now on.
>>
>> Tested in tiers 1 - 7.
>
> Anton Artemov has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8359437: Addressed reviewer's comments.
test/hotspot/jtreg/runtime/Monitor/ConcurrentDeflation.java line 79:
> 77: }
> 78:
> 79: static private void createMonitors() throws InterruptedException {
I would have put the try/catch around the wait to minimise the number of
changes.
test/hotspot/jtreg/runtime/Monitor/ConcurrentDeflation.java line 86:
> 84: monitors[index] = new Object();
> 85: synchronized (monitors[index]) {
> 86: monitors[index].wait(1);
Suggestion:
// Force inflation
monitors[index].wait(1);
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25847#discussion_r2163523429
PR Review Comment: https://git.openjdk.org/jdk/pull/25847#discussion_r2163521570
