On Wed, 14 May 2025 15:44:08 GMT, Jiangli Zhou <jian...@openjdk.org> wrote:

>> Please review this PR for skipping 
>> jdk/test/lib/process/TestNativeProcessBuilder on static-jdk. Duplicating the 
>> context from https://bugs.openjdk.org/browse/JDK-8356904 description:
>> 
>> jdk/test/lib/process/TestNativeProcessBuilder.java (in lib-test/tier1) uses 
>> a native test launcher executable, exejvm-test-launcher, which has 
>> explicitly dependency on libjvm.so. The test fails on static-jdk. This is 
>> the same issue as 
>> [JDK-8352276](https://bugs.openjdk.org/browse/JDK-8352276). With 
>> [JDK-8352276](https://bugs.openjdk.org/browse/JDK-8352276), we decided to 
>> skip the affected hotspot tier1 tests on static-jdk. We should skip 
>> jdk/test/lib/process/TestNativeProcessBuilder.java on static-jdk as well. 
>> [JDK-8352305](https://bugs.openjdk.org/browse/JDK-8352305) will add tests 
>> using custom launcher executable on static JDK.
>
> Jiangli Zhou has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Update copyright year in 
> test/lib-test/jdk/test/lib/process/TestNativeProcessBuilder.java.

lgtm

-------------

Marked as reviewed by rriggs (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/25220#pullrequestreview-2858791041

Reply via email to