On Wed, 7 May 2025 02:07:03 GMT, Alexander Matveev <almat...@openjdk.org> wrote:

>> - Symbolic links will not be followed for `--app-content` on all platforms.
>> - Added test to cover this case.
>> - `MacHelper` updated to use "cp -R" instead of "cp -r" when unpacking DMG, 
>> since "cp -r" on macOS is not documented option and when used `cp` will 
>> follow symbolic links which breaks test. "cp -R" does not follow symbolic 
>> links.
>
> Alexander Matveev has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   8352480: [macos] Don't follow symlinks in additional content for app images 
> [v5]

8352480: [macos] Don't follow symlinks in additional content for app images [v6]
-  Fixed latest comments.
- Link will be created under "Links" folder to avoid confusion with reusing 
"Resources"
- Link creation moved under separate function `createAppContentLink` from 
`copyAppContentPath` to avoid confusion.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24974#issuecomment-2864851703

Reply via email to