On Tue, 22 Apr 2025 18:56:40 GMT, Stuart Marks <sma...@openjdk.org> wrote:
>> src/java.base/share/classes/java/lang/IO.java line 41:
>>
>>> 39: * The {@link #readln()} and {@link #readln(String)} methods decode
>>> bytes read from
>>> 40: * {@code System.in} into characters. The charset used for decoding is
>>> specified by the
>>> 41: * {@link System#getProperties stdin.encoding} property. If this
>>> property is not present,
>>
>> @stuart-marks Are you planning to propose/integrate pull/24738 in advance of
>> the JEP update? Asking because this paragraph will need to be adjusted if
>> pull/24738 doesn't go in first.
>
> Depends on how close you think 24738 is to being ready. As it stands it seems
> ok; but I'm still looking at the potential impact on other part of the JDK.
> In particular are there other JDK APIs that should be adjusted to mention
> `stdin.encoding`?
>
> As for the impact here, if 24738 doesn't go in first, then I'm not quite sure
> what this should say. I guess it could say "default charset" or something and
> then it could be amended with a bugfix later.
(After some further discussion, it looks like 24738 is quite close to being
ready.)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24438#discussion_r2058832242
