On Mon, 7 Apr 2025 17:58:45 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> Jan Lahoda has updated the pull request incrementally with seven additional >> commits since the last revision: >> >> - Merge remote-tracking branch 'origin/finalize-concise-source-files' into >> finalize-concise-source-files >> - Reverting test commit. >> >> This reverts commit 7047cf007cc7de937aa21e96125083ee92932692. >> - Fixing tests. >> - Updating copyright year. >> - Adding bug number to tests. >> - Fixing IO tests path >> - Scratch > > test/jdk/java/lang/IO/IO/IO.java line 1: > >> 1: /* > > Is there reason to create a test subdirectory `IO` under `java.lang.IO` > package? Sorry, I missed this comment. Fixed here: https://github.com/openjdk/jdk/pull/24438/commits/bacc1a2aa0251cc099d667b3ad5628ca1fc33446 > test/jdk/java/lang/IO/IO/IO.java line 53: > >> 51: /* >> 52: * @test >> 53: * @bug 8305457 8342936 8351435 > > Issue id needs to be added (and other test files too) Sorry, I missed this comment. Fixed here: https://github.com/openjdk/jdk/pull/24438/commits/5d02ff6f34e20374627d0ef0b31e9db4e1bf6f2b ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24438#discussion_r2054024689 PR Review Comment: https://git.openjdk.org/jdk/pull/24438#discussion_r2054025088
