On Fri, 18 Apr 2025 21:26:23 GMT, Joe Wang <jo...@openjdk.org> wrote:

>> Fix a NPE on calling DocumentBuilderFactory::getAttribute, refer to the bug 
>> report.
>> 
>> Also in this patch: consolidates get and set properties to use the same Util 
>> methods to reduce potential errors when code changes.
>> 
>> Test:
>>     Tier1 - 3 passed
>>     JCK test passed
>
> Joe Wang has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   remove unused variable pName; remove unused imports

Changes requested by syan (Committer).

test/jaxp/javax/xml/jaxp/unittest/common/PropertiesTest.java line 47:

> 45:  * @summary Verifies JAXP API Properties as specified in the java.xml 
> module.
> 46:  * @library /javax/xml/jaxp/libs /javax/xml/jaxp/unittest /test/lib
> 47:  * @run junit/othervm common.PropertiesTest

`/othervm` seems do not needed

-------------

PR Review: https://git.openjdk.org/jdk/pull/24732#pullrequestreview-2780134426
PR Review Comment: https://git.openjdk.org/jdk/pull/24732#discussion_r2051623145

Reply via email to