On Tue, 15 Apr 2025 21:23:20 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> Johannes Graham has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Terminate test early on failure > > test/jdk/java/text/Format/DecimalFormat/CloneTest.java line 77: > >> 75: String str = String.valueOf(value); >> 76: if (!str.equals(dfString)) { >> 77: mismatchCount.getAndIncrement(); > > `mismatchCount` is no longer needed. Simply break after printing the error > message would suffice. It would still need something to indicate that it had failed, as well as a way to signal other threads that they should terminate early. Worth changing to an AtomicBoolean? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24598#discussion_r2045572553