On Tue, 15 Apr 2025 19:18:03 GMT, Naoto Sato <na...@openjdk.org> wrote:

>> For the original reproducer I wanted to be _really_ sure that it failed. 
>> I've reduced it to be more reasonable. With the current config it still gets 
>> 10-100 mismatches for me. I've limited the number of lines that get logged 
>> as well.
>
> If a mismatch is found, I think we can stop there and report error

My thinking was that for a test pass, it would never hit the shortcut anyway, 
so it’s only an optimization for the failure case, which hopefully won’t happen 
anymore. Seeing the count of all collisions gives some reassurance that the 
test is still running for long enough to be effective.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24598#discussion_r2045393947

Reply via email to