On Mon, 14 Apr 2025 15:23:45 GMT, Vladimir Ivanov <vaiva...@openjdk.org> wrote:
>> src/java.xml/share/classes/com/sun/org/apache/xml/internal/utils/XMLReaderManager.java
>> line 148:
>>
>>> 146: // for this thread, remove it.
>>> 147: ReaderWrapper rw = m_readers.get();
>>> 148: if (rw != null && rw.reader == reader && reader != null) {
>>
>> Suggestion:
>>
>> if (rw != null && rw.reader == reader) {
>
> For the first glance, some parameters check should be OK for public method.
> Seems, the rw.reader should not be 'null' now if 'rw' was initialized but it
> is small check not in the 'hot' path. It may be OK to have it.
Yes, it was nit.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23185#discussion_r2042534343
