On Fri, 11 Apr 2025 10:13:41 GMT, Jatin Bhateja <[email protected]> wrote:
>> Vladimir Ivanov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8346230: [perf] scalability issue for the specjvm2008::xml.transform
>> workload
>
> src/java.xml/share/classes/com/sun/org/apache/xml/internal/utils/XMLReaderManager.java
> line 148:
>
>> 146: // for this thread, remove it.
>> 147: ReaderWrapper rw = m_readers.get();
>> 148: if (rw != null && rw.reader == reader && reader != null) {
>
> Suggestion:
>
> if (rw != null && rw.reader == reader) {
For the first glance, some parameters check should be OK for public method.
Seems, the rw.reader should not be 'null' now if 'rw' was initialized but it is
small check not in the 'hot' path. It may be OK to have it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23185#discussion_r2042387492
