On Fri, 28 Mar 2025 09:55:25 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:
>> Joachim Kern has updated the pull request incrementally with one additional >> commit since the last revision: >> >> add !windows again and remove @compile > > test/jdk/tools/launcher/ExecutionEnvironment.java line 42: > >> 40: * LD_LIBRARY_PATH if set are not modified in any way. >> 41: * 3. the correct vm is chosen with -server and -client options >> 42: * 4. no extra symlink exists on Solaris i.e. > > You can remove Solaris, we do not build/test on Solaris for some time . I think it is wrong to completely remove point 4. You should rather remove the term "on Solaris". The thing itself is still tested in testNoSymLink(). ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24055#discussion_r2018408222
