On Wed, 26 Mar 2025 13:05:46 GMT, Viktor Klang <vkl...@openjdk.org> wrote:
>> Doug Lea has updated the pull request with a new target base due to a merge >> or a rebase. The pull request now contains 49 commits: >> >> - Merge branch 'openjdk:master' into JDK-8319447 >> - Address review comments >> - Merge branch 'openjdk:master' into JDK-8319447 >> - Match indent of naster changes >> - Use TC_MASK in accord with https://bugs.openjdk.org/browse/JDK-8330017 >> (Unnecessarily for now.) >> - Reword javadoc >> - Use SharedSecrets for ThreadLocalRandomProbe; other tweaks >> - Disambiguate caller-runs vs Interruptible >> - Merge branch 'openjdk:master' into JDK-8319447 >> - Associate probes with carriers if Virtual (no doc updates yet) >> - ... and 39 more: https://git.openjdk.org/jdk/compare/dbc620fb...4aabe6b0 > > src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 3559: > >> 3557: return scheduleDelayedTask( >> 3558: new ScheduledForkJoinTask<V>( >> 3559: unit.toNanos(delay), 0L, false, null, > > Suggestion: > > unit.toNanos(delay), 0L, false, null, // implicit null check > of unit Thanks, done. > src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 3612: > >> 3610: return scheduleDelayedTask( >> 3611: new ScheduledForkJoinTask<Void>( >> 3612: unit.toNanos(initialDelay), > > Suggestion: > > unit.toNanos(initialDelay), // implicit null check of unit Done > src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 3661: > >> 3659: return scheduleDelayedTask( >> 3660: new ScheduledForkJoinTask<Void>( >> 3661: unit.toNanos(initialDelay), > > Suggestion: > > unit.toNanos(initialDelay), // implicit null check of unit Done > src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 3724: > >> 3722: ScheduledForkJoinTask<Void> timeoutTask = >> 3723: new ScheduledForkJoinTask<Void>( >> 3724: unit.toNanos(timeout), 0L, true, > > Suggestion: > > unit.toNanos(timeout), 0L, true, // implicit null check of > unit Done ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23702#discussion_r2014893575 PR Review Comment: https://git.openjdk.org/jdk/pull/23702#discussion_r2014893766 PR Review Comment: https://git.openjdk.org/jdk/pull/23702#discussion_r2014893994 PR Review Comment: https://git.openjdk.org/jdk/pull/23702#discussion_r2014894193
