On Wed, 19 Mar 2025 17:48:20 GMT, Naoto Sato <na...@openjdk.org> wrote:

>> Upgrading the CLDR to version 47.0. A corresponding CSR has also been 
>> drafted.
>
> Naoto Sato has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Copyright year/bugid update

Spec change in spi and test changes LGTM. Spot checked some data which 
corresponds to v47. (E.g. en-AU time zone name changes)

test/jdk/sun/util/resources/cldr/LikelySubtagLocalesTest.java line 44:

> 42:     public static final List<Locale> AVAILABLE_LOCALES = 
> Arrays.asList(Locale.getAvailableLocales());
> 43: 
> 44:     /* Samples of locales that do not exist as .xml CLDR source files, 
> but derived from

New test looks good and is easier to understand. It was unclear to me why the 
previous test said "_Tests LikelySubtags is correctly reflected in 
Locale.getAvailableLocales()_" when it was testing all of the non-inferred 
locale tags.

-------------

Marked as reviewed by jlu (Committer).

PR Review: https://git.openjdk.org/jdk/pull/24120#pullrequestreview-2703662674
PR Review Comment: https://git.openjdk.org/jdk/pull/24120#discussion_r2006187889

Reply via email to