On Thu, 20 Mar 2025 18:04:49 GMT, Justin Lu <j...@openjdk.org> wrote:
>> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Copyright year/bugid update > > test/jdk/sun/util/resources/cldr/LikelySubtagLocalesTest.java line 44: > >> 42: public static final List<Locale> AVAILABLE_LOCALES = >> Arrays.asList(Locale.getAvailableLocales()); >> 43: >> 44: /* Samples of locales that do not exist as .xml CLDR source files, >> but derived from > > New test looks good and is easier to understand. It was unclear to me why the > previous test said "_Tests LikelySubtags is correctly reflected in > Locale.getAvailableLocales()_" when it was testing all of the non-inferred > locale tags. Thanks Justin. The test has been checking *all* the available locales which should contain likelySubtag inferred ones. While this ensures comprehensive testing, it is not practical to logically derive the expected locale sets, as it is not as simple as listing .xml files + likelySubtag inferred. Maintaining the locale set per CLDR release does not seem practical, which is why this change was made. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24120#discussion_r2006276054
