On Mon, 24 Feb 2025 22:20:27 GMT, Alexander Matveev <almat...@openjdk.org>
wrote:
> Currently it sounds that CLI option "--install-dir" is not supported, but it
> will work if it points to default location.
The warning will be shown only if `--install-dir` doesn't point to the default
location. This is the change from the current behavior when the warning is
shown if the `--install-dir` option is present on the command line regardless
of its value.
If they pass `--install-dir /Applications` they will not see the warning.
If they pass, say `--install-dir /opt` they will see the warning. Currently, it
will be:
Warning: "--install-dir" is not supported by DMG and will be default to
/Applications.
Do you prefer:
Warning: "--install-dir" value "/opt" is not supported by DMG and will be
default to /Applications.
?
If we want to improve the warning text additionally to making it accurate for
runtime packaging, I'd rather have this wording:
Warning: "--install-dir" option is ignored for DMG packaging. The installation
directory will default to {0}.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23752#discussion_r1968647620
