On Thu, 20 Feb 2025 16:21:16 GMT, Brian Burkhalter <b...@openjdk.org> wrote:

>> test/jdk/java/io/File/EmptyPath.java line 67:
>> 
>>> 65: 
>>> 66:     @Test
>>> 67:     @Order(1)
>> 
>> What is the reason for use `@Order` in these tests, is there a dependency? 
>> Asking because we've usually avoided need to do this and I'm trying to see 
>> if how someone might be able to add to this test in the future.
>
> Early on I had some concern about the state being affected in a way that 
> would make some tests spuriously fail if they were not performed before 
> others. I think with careful handling of resetting the state as suggested 
> above ("Need try-finally in the setter tests") then the `Order` annotations 
> can be removed.

`Order` removed in a3b7977; no effect on results.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22821#discussion_r1964415314

Reply via email to