On Thu, 20 Feb 2025 07:52:43 GMT, Alan Bateman <[email protected]> wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8024695: Extend and clean up test
>
> test/jdk/java/io/File/EmptyPath.java line 67:
>
>> 65:
>> 66: @Test
>> 67: @Order(1)
>
> What is the reason for use `@Order` in these tests, is there a dependency?
> Asking because we've usually avoided need to do this and I'm trying to see if
> how someone might be able to add to this test in the future.
Early on I had some concern about the state being affected in a way that would
make some tests spuriously fail if they were not performed before others. I
think with careful handling of resetting the state as suggested above ("Need
try-finally in the setter tests") then the `Order` annotations can be removed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22821#discussion_r1963925038
