> Please review this change that adds the `jdk.static` VMProps. It can be used 
> to skip tests not for running on static JDK.
> 
> This also adds a new WhiteBox native method, 
> `jdk.test.whitebox.WhiteBox.isStatic()`, which is used by VMProps to 
> determine if it's static at runtime. 
> 
> `@requires !jdk.static` is added in 
> `test/hotspot/jtreg/runtime/modules/ModulesSymLink.java` to skip running the 
> test on static JDK. This test uses `bin/jlink`, which is not provided on 
> static JDK. There are other tests that require tools in `bin/`. Those are not 
> modified by the current PR to skip running on static JDK. Those can be done 
> after the current change is fully discussed and reviewed/approved.

Jiangli Zhou has updated the pull request with a new target base due to a merge 
or a rebase. The incremental webrev excludes the unrelated changes brought in 
by the merge/rebase. The pull request contains two additional commits since the 
last revision:

 - Merge branch 'master' into JDK-8349620
 - - Add 'jdk.static' in VMProps. It can be used to skip tests not for running 
on static JDK.
   - Add WhiteBox isStatic() native method. It's used by VMProps to determine 
of it's static at runtime.
   - Add in '@requires !jdk.static' in 
test/hotspot/jtreg/runtime/modules/ModulesSymLink.java to skip the test on 
static JDK since it requires bin/jlink.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/23528/files
  - new: https://git.openjdk.org/jdk/pull/23528/files/e01ce5b1..e4d2e49e

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=23528&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=23528&range=00-01

  Stats: 19883 lines in 961 files changed: 13314 ins; 3171 del; 3398 mod
  Patch: https://git.openjdk.org/jdk/pull/23528.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/23528/head:pull/23528

PR: https://git.openjdk.org/jdk/pull/23528

Reply via email to