On Mon, 10 Feb 2025 08:21:21 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Please review this change that adds the `jdk.static` VMProps. It can be used >> to skip tests not for running on static JDK. >> >> This also adds a new WhiteBox native method, >> `jdk.test.whitebox.WhiteBox.isStatic()`, which is used by VMProps to >> determine if it's static at runtime. >> >> `@requires !jdk.static` is added in >> `test/hotspot/jtreg/runtime/modules/ModulesSymLink.java` to skip running the >> test on static JDK. This test uses `bin/jlink`, which is not provided on >> static JDK. There are other tests that require tools in `bin/`. Those are >> not modified by the current PR to skip running on static JDK. Those can be >> done after the current change is fully discussed and reviewed/approved. > > I think this looks okay, I'm just wondering is one property is enough to > cover all the configurations. Thanks, @AlanBateman. > I'm just wondering is one property is enough to cover all the configurations. +1 It's not easy to predict all different cases for now. How about adding/refining when we find any new cases? I'm also wondering if we would want to merge the `isStatic` into `isHermetic` check in the future. ------------- PR Comment: https://git.openjdk.org/jdk/pull/23528#issuecomment-2649588820
