On Mon, 10 Feb 2025 20:43:19 GMT, Paul Sandoz <psan...@openjdk.org> wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixing typos
>
> test/jdk/jdk/incubator/vector/ScalarFloat16OperationsTest.java line 44:
>
>> 42: import static jdk.incubator.vector.Float16.*;
>> 43:
>> 44: public class ScalarFloat16OperationsTest {
>
> Now that we have IR tests do you still think this test is necessary or should
> we have more IR test instead? @eme64 thoughts? We could follow up in another
> PR if need be.
Hi Paul, DataProviders used in this Functional validation test exercises each
newly added Float16 operation over entire value range, while our IR tests are
more directed towards valdating the newly added IR transforms and constant
folding scenarios. We have a follow-up PR for auto-vectorizing Float16
operation which can be used to beefup any validation gap.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22754#discussion_r1950290083
