On Mon, 10 Feb 2025 18:54:26 GMT, Chen Liang <li...@openjdk.org> wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> copyright > > Re dougxc: This migration is specific to the Java language. I am not so sure > about the C++ counterparts, especially that C++ has unsigned types that can > complicate things. Another motivation of the Java change is that unsafe is > widely used in the Java codebase so upgrading the type can potentially make > future usages safer. For example, this already revealed a misuse of the array > base offset in the benchmarks in #23393. Thanks for the clarification @liach . This means we only need to focus on the Java code in https://bugs.openjdk.org/browse/JDK-8349743 (cc @mur47x111). ------------- PR Comment: https://git.openjdk.org/jdk/pull/22095#issuecomment-2649300214