On Wed, 22 Jan 2025 23:41:18 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:

>> Ioi Lam has updated the pull request with a new target base due to a merge 
>> or a rebase. The incremental webrev excludes the unrelated changes brought 
>> in by the merge/rebase. The pull request contains three additional commits 
>> since the last revision:
>> 
>>  - Merge branch 'master' into 
>> 8348240-remove-lookup_super_for_unregistered_class
>>  - @calvinccheung comments
>>  - 8348240: Remove 
>> SystemDictionaryShared::lookup_super_for_unregistered_class()
>
> I like this change a lot, except for the name "unregistered" but that can be 
> taken up in some other way.  If I understand correctly, this just creates a 
> dummy class loader to load the classes you want to share from the non-boot, 
> app or system class loader.

Thanks @coleenp @calvinccheung for the review.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23226#issuecomment-2611107641

Reply via email to