On Thu, 23 Jan 2025 01:04:05 GMT, Calvin Cheung <cche...@openjdk.org> wrote:
>> Ioi Lam has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains three additional commits >> since the last revision: >> >> - Merge branch 'master' into >> 8348240-remove-lookup_super_for_unregistered_class >> - @calvinccheung comments >> - 8348240: Remove >> SystemDictionaryShared::lookup_super_for_unregistered_class() > > src/hotspot/share/cds/unregisteredClasses.cpp line 72: > >> 70: >> 71: JavaValue result(T_OBJECT); >> 72: JavaCallArguments args(2); > > Should the 2 be increased to 3? I changed it to 3. I wonder why the 2 didn't fail. It turns out that `JavaCallArguments` reserves at least 8 slots. > src/hotspot/share/classfile/vmSymbols.hpp line 742: > >> 740: template(toFileURL_name, >> "toFileURL") \ >> 741: template(toFileURL_signature, >> "(Ljava/lang/String;)Ljava/net/URL;") \ >> 742: template(url_array_classloader_void_signature, >> "([Ljava/net/URL;Ljava/lang/ClassLoader;)V") \ > > I think you can also remove the following since `URLClassLoader` is not used > directly anymore: > `do_klass(URLClassLoader_klass, > java_net_URLClassLoader ) ` Removed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23226#discussion_r1926270349 PR Review Comment: https://git.openjdk.org/jdk/pull/23226#discussion_r1926270410
