On Fri, 20 Dec 2024 13:11:15 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> make/common/modules/LauncherCommon.gmk line 162: >> >>> 160: -framework ApplicationServices \ >>> 161: -framework Cocoa \ >>> 162: -framework Security, \ >> >> What happened to all of these? Were they never needed? > > I don't know. If so, it was a long time ago. > > Hm, maybe it was from when JLI was statically linked. It could actually be > that we still need something like: > > LIB_aix := $(LIBZ_LIBS), \ > > > Perhaps someone from the AIX team can check this? It seems they were required for the static launcher, which I obviously did not test with this change. :-( I should add `static-launcher` to the `launchers` target, so I don't forget about it again. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22832#discussion_r1913747211