On Thu, 19 Dec 2024 16:27:30 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
> We need to raise the abstraction of the SetupBuildLauncher API, to prepare > for static launchers. We should specify the desired outcome, not what flags > we should add. This can be seen as the last part of > [JDK-8141444](https://bugs.openjdk.org/browse/JDK-8141444) (9 years later). > > In the process, I am removing EXTRA_JAVA_ARGS which has not been used for a > long time. I also removed this part from the launcher itself. make/common/modules/LauncherCommon.gmk line 73: > 71: endif > 72: > 73: ifeq ($$($1_MAIN_MODULE), ) Why was this check removed? Is MAIN_MODULE no longer needed? make/common/modules/LauncherCommon.gmk line 85: > 83: > 84: ifeq ($(call isTargetOs, windows), true) > 85: ifeq ($$($1_WINDOWS_JAVAW), true) WINDOWS_JAVAW sounds a bit clunky. Does just JAVAW work instead? Not really that important, feel free to ignore this if you prefer the existing name ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22832#discussion_r1894010417 PR Review Comment: https://git.openjdk.org/jdk/pull/22832#discussion_r1894011569
