On Wed, 18 Dec 2024 06:22:56 GMT, Emanuel Peter <epe...@openjdk.org> wrote:
>> @eme64 I've addressed all your comments except aarch64 testing. `asimd` is >> not enough, you need `sve` for this, but I'm yet to make it work even with >> `sve`, something's up and need to debug it further. >> >> @jaskarth FYI I've adjusted the expectations in `TestMinMaxIdentities` after >> this change (thx for adding the test!). Check if there's any >> comments/changes you'd like. > > @galderz Nice, thanks for the updates. I gave the patch a quick scan and I > think it looks really good. Just ping me again when you are done with your > aarch64 investigations, and you think I should review again :) @eme64 aarch64 work for this is now complete. I tweaked the `applyIf` condition `MinMaxRed_Long` to make sure `MaxVectorSize` is 32 or higher. I verified this on both Graviton 3 (256 bit register, `MaxVectorSize=32`) and an AVX-512 intel (512 bit register, `MaxVectorSize=64`) ------------- PR Comment: https://git.openjdk.org/jdk/pull/20098#issuecomment-2579989885
