On Tue, 17 Dec 2024 18:20:36 GMT, Galder Zamarreño <gal...@openjdk.org> wrote:
>> @galderz Yes, there is significant duplication, sadly. Often there were old >> tests there, but then one comes along and sees that one wants to have more >> comprehensive tests. So one adds it, but does not feel 100% comfortable >> removing old tests. A little bit of duplication is probably ok. Often, there >> are still subtle differences, and sometimes those end up mattering. >> >> `compiler/loopopts/superword/MinMaxRed_Long.java` sounds like a good idea. > > @eme64 I've addressed all your comments except aarch64 testing. `asimd` is > not enough, you need `sve` for this, but I'm yet to make it work even with > `sve`, something's up and need to debug it further. > > @jaskarth FYI I've adjusted the expectations in `TestMinMaxIdentities` after > this change (thx for adding the test!). Check if there's any comments/changes > you'd like. @galderz Nice, thanks for the updates. I gave the patch a quick scan and I think it looks really good. Just ping me again when you are done with your aarch64 investigations, and you think I should review again :) ------------- PR Comment: https://git.openjdk.org/jdk/pull/20098#issuecomment-2550456266
