On Mon, 23 Dec 2024 19:42:34 GMT, Kim Barrett <kbarr...@openjdk.org> wrote:
>> I strongly suggest avoiding omnibus changes like this when possible (which it >> is here). Just because it's all about one "kind" of change doesn't make it a >> cohesive change. This is touching many distinct areas of the JDK, and several >> different languages as well. That makes it harder to review and to manage the >> review, because it is large and affects a wide range of areas, so may need >> many reviewers. And the whole thing might get stalled by discussion of one >> piece. >> >> There is also no mention of what testing has been done for this PR. Some of >> the changes are in executable code, and need to be tested. >> >> I think that all of the files in make/data/cldr/common are from the Unicode >> Consortium, and should not be modified here. > >> That makes it harder to review and to manage the review, because it is large >> and affects a wide range of areas, so may need many reviewers. > > And many of the appropriate reviewers might be unavailable for a while, since > it's right before Christmas. @kimbarrett @liach Thanks for your suggestions! I've moved the fix for the CTW Makefile to a separate pull request: https://github.com/openjdk/jdk/pull/22878, please check it. ------------- PR Comment: https://git.openjdk.org/jdk/pull/22861#issuecomment-2561558033
