On Tue, 24 Dec 2024 22:22:28 GMT, Kim Barrett <kbarr...@openjdk.org> wrote:
>> Only this small piece would be appropriate for backport to 24. I suggest >> splitting this out into its own bug, >> fixing it in isolation, and backporting that. > > The purpose of this Makefile seems to be to build ctw.jar. So far as I can > tell, nothing in the JDK uses that jar, > or invokes that Makefile. There are some tests for the ctw component in > hotspot/jtreg/testlibrary_tests/ctw. I > think if you ran tier4 testing that you would hit those. Or you could use > `TEST=hotspot:hotspot_misc`, or > specify that directory. But those tests don't appear to use that jar. So I > think there isn't a test that touches > this Makefile. This makefile is not used by jtreg tests. The ctw code is compiled with `@library /test/lib / /testlibrary/ctw/src` so jtreg compiled the ctw library files itself. This makefile might be used for standalone build if needed. Thanks for fixing this! ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22861#discussion_r1897036236
