On Thu, 12 Dec 2024 09:57:11 GMT, Severin Gehwolf <sgehw...@openjdk.org> wrote:
>> Personally, I find it less clear to call it `newModuleFinder`. What it does >> is that it creates a finder based on the passed in finder that "finds" fewer >> modules. How about `newLimitedFinder()`? But no strong feelings, so if you >> think it should be `newModuleFinder` then it's fine by me. > > I went with `newLimitedFinder`. Hope that's ok. This suggestion was mainly caused as this is used by the test which raises the question what is a limit finder. `newModuleFinder` was the original method name and the javadoc specifies what it does. Anyway, you can reconsider in #22494. >> The parameter is also passed to `JlinkConfiguration` constructor. That still >> has the parameter. > > I've re-formated the code to make this clearer. I see. Thanks. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22609#discussion_r1882576879 PR Review Comment: https://git.openjdk.org/jdk/pull/22609#discussion_r1882583489
