On Mon, 2 Dec 2024 18:48:39 GMT, Mandy Chung <mch...@openjdk.org> wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 15 additional >> commits since the last revision: >> >> - Merge branch 'master' into jdk-8343839-detect-patch-module >> - Use ModuleBootStrap for detecting patches >> - Revert "8344560: Add system property for patched runtime" >> >> This reverts commit 1d2395f39ee95a80937c63713e1f874ecc4ae76e. >> - Revert "Move and amend test" >> >> This reverts commit c27c874b4c722aa4cfa5f6c71f9231e92a30db0c. >> - Revert "Set the property to false for unpatched, expand tests" >> >> This reverts commit c635fdc0ad09c68ef652afb516c221b3c3a6299f. >> - Revert "Mention jdk.patched in System class" >> >> This reverts commit a11e26637d89d5ae840753eabcfe6deb2ac025be. >> - Merge branch 'jdk-8344560-jdk.patched-property' into >> jdk-8343839-detect-patch-module >> - Mention jdk.patched in System class >> - Set the property to false for unpatched, expand tests >> - Move and amend test >> - ... and 5 more: https://git.openjdk.org/jdk/compare/f947cdec...77695cea > > src/jdk.jlink/share/classes/jdk/tools/jlink/resources/jlink.properties line > 129: > >> 127: err.runtime.link.modified.file={0} has been modified >> 128: err.runtime.link.patched.module=The current runtime has been patched >> with --patch-module.\ >> 129: \ --patch-module is not supported when linking from the run-time image > > Suggestion: > > err.runtime.link.patched.module=jlink does not support linking from the > run-time image when running on a patched runtime with --patch-module > > > This error message seems more direct. OK, thanks! ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22037#discussion_r1867785643
