On Mon, 2 Dec 2024 14:26:08 GMT, Maurizio Cimadamore <mcimadam...@openjdk.org> wrote:
>> As this is an internal API, I tried to keep it as similar as possible to the >> other bulk operations. But as you say, the value used here for the last >> parameter is always `segment.byteSize()`. We could easily change it. What's >> your preference here? > > If the method works correctly on all end offsets (even when the offset is > different from the segment size), then I'm ok leaving it as is. I'm mostly > trying to make sure that endOffset = size is not an hidden invariant we > depend on. I've added a test for the end offset. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22451#discussion_r1866102021
