On Wed, 20 Nov 2024 19:39:58 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
> This PR remove usage of SecurityManager, doPrivileges, etc... from
> `java.logging` and `java.base/jdk.internal.logger`
>
> Only notable hack - Logger.checkPermission() no longer checks permissions,
> but has been renamed into `ensureLogManagerInitialized()` in order to avoid
> disturbing the initialization sequence of Logger/LogManager.
>
> I am not 100% sure this is still needed - but I remember we had some
> entanglement issues in the past that had been hard to solve, so it seemed
> prudent to keep the call:
>
>
> if (manager == null) {
> manager = LogManager.getLogManager();
> }
>
>
> where `manager` is a private volatile field in Logger.
Hello Daniel, the changes look good to me. However, these changes appear to
include both JEP 486 related updates as well as the JEP 491 (the reverting of
`ReentrantLock` usage in favour of `synchronized`). Doing this clean up
together I think is fine. However, I think we should update the issue title to
also include JEP 491 in addition to JEP 486.
-------------
PR Review: https://git.openjdk.org/jdk/pull/22281#pullrequestreview-2450405988
