On Sat, 16 Nov 2024 18:11:32 GMT, Chen Liang <li...@openjdk.org> wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> prev is not needed > > test/jdk/jdk/internal/ref/Cleaner/CleanableListTest.java line 30: > >> 28: * @compile/module=java.base >> jdk/internal/ref/CleanableListTestHelper.java >> jdk/internal/ref/TestCleanable.java >> 29: * @modules java.base/jdk.internal.ref >> 30: * @run testng/othervm --add-exports >> java.base/jdk.internal.ref=ALL-UNNAMED CleanableListTest > > I don't think you need this --add-exports flag; JTReg modules tag should take > care of it for you. Indeed. I'll drop it in next update. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22043#discussion_r1846163165
