On Fri, 15 Nov 2024 17:53:53 GMT, Chen Liang <li...@openjdk.org> wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Do not need -ea -esa in tests, our testing infra adds them already > > src/java.base/share/classes/jdk/internal/ref/CleanerImpl.java line 249: > >> 247: * the time. >> 248: */ >> 249: private Node cache; > > Should the cache be soft, as it keeps the 4096-long array reachable? Not > familiar with this matter, please enlighten me. I don't think this is necessary. Cleaners are supposed to be shared, so this list is supposed to be global. We are not winning much by using soft refs for this single-node cache. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22043#discussion_r1844358093
