On Thu, 14 Nov 2024 21:03:35 GMT, Brent Christian <bchri...@openjdk.org> wrote:
>> Nevermind, I added a directed regression test for it now. > >> I see that existing `Cleaner` tests are quite rich already. >> ... >> The new asserts around that code should IMO test enough with existing tests. > > Should any of the existing `Cleaner` tests have `@run`s added with `-esa` ? RunTests.gmk adds -ea -esa so the testing is done with asserts enabled when using "make run-test". ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22043#discussion_r1843254523