On Fri, 1 Nov 2024 14:36:39 GMT, Roger Riggs <rri...@openjdk.org> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Roger's suggestion - introduce log message to match unix/windows
>
> src/java.base/macosx/native/libjli/java_md_macosx.m line 432:
>
>> 430: }
>> 431: }
>> 432: /* ensure storage for path + /jre + NULL */
>
> The corresponding changes in JDK-8329862 included adding a call to
> JLI_TraceLauncher.
> Such as:
> ` JLI_TraceLauncher("Attempt to get JDK installation root from launcher
> executable path\n");
> `
> Adding a similar trace message would be consistent across platforms.
That's a good point. I've now updated the PR to add the same log message as the
one present in unix/windows variant of this code.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21789#discussion_r1825910349
