On Fri, 25 Oct 2024 04:34:00 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Check output for including values rather than exact match.
>> Also include the manpage change and revert the problem list.
>
> test/jdk/tools/jar/MultipleManifestTest.java line 203:
>
>> 201:
>> 202: private void assertOutputContains(String expected) {
>> 203: Assertions.assertTrue(baos.toString().contains(expected));
>
> The linked JBS issue notes that the test was failing because of the
> additional (new) log messages from the jar tool itself. So I think the logs
> will be deterministic (since they aren't being generated by something else
> other than the jart tool). Using `contains()` thus looks fine to me.
Do you think we should print out the actual and expected, when they don't
match? It might make it easier to debug any unexpected failures in future.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21697#discussion_r1815981958
