On Thu, 24 Oct 2024 13:59:58 GMT, Jatin Bhateja <jbhat...@openjdk.org> wrote:
>> src/hotspot/cpu/x86/x86.ad line 10593: >> >>> 10591: match(Set dst (SaturatingAddV src1 src2)); >>> 10592: match(Set dst (SaturatingSubV src1 src2)); >>> 10593: format %{ "vector_addsub_saturating_subword $dst, $src1, $src2" %} >> >> Could the `Opcode` be put into the `format` string? Not strictly necessary, >> but would be neat. > > Desirable future extension, but its not related to this specific PR. Well, here it would be especially interesting, because it would tell us if we have a `sub` or an `add`. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20507#discussion_r1815058565