On Thu, 24 Oct 2024 13:36:50 GMT, Jatin Bhateja <jbhat...@openjdk.org> wrote:
>> Hi All, >> >> As per the discussion on panama-dev mailing list[1], patch adds the support >> for following new vector operators. >> >> >> . SUADD : Saturating unsigned addition. >> . SADD : Saturating signed addition. >> . SUSUB : Saturating unsigned subtraction. >> . SSUB : Saturating signed subtraction. >> . UMAX : Unsigned max >> . UMIN : Unsigned min. >> >> >> New vector operators are applicable to only integral types since their >> values wraparound in over/underflowing scenarios after setting appropriate >> status flags. For floating point types, as per IEEE 754 specs there are >> multiple schemes to handler underflow, one of them is gradual underflow >> which transitions the value to subnormal range. Similarly, overflow >> implicitly saturates the floating-point value to an Infinite value. >> >> As the name suggests, these are saturating operations, i.e. the result of >> the computation is strictly capped by lower and upper bounds of the result >> type and is not wrapped around in underflowing or overflowing scenarios. >> >> Summary of changes: >> - Java side implementation of new vector operators. >> - Add new scalar saturating APIs for each of the above saturating vector >> operator in corresponding primitive box classes, fallback implementation of >> vector operators is based over it. >> - C2 compiler IR and inline expander changes. >> - Optimized x86 backend implementation for new vector operators and their >> predicated counterparts. >> - Extends existing VectorAPI Jtreg test suite to cover new operations. >> >> Kindly review and share your feedback. >> >> Best Regards, >> PS: Intrinsification and auto-vectorization of new core-lib API will be >> addressed separately in a follow-up patch. >> >> [1] https://mail.openjdk.org/pipermail/panama-dev/2024-May/020408.html > > Jatin Bhateja has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 37 commits: > > - Review resolutions. > - Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8338201 > - Factor out IR tests and Transforms to follow-up PRs. > - Replacing flag based checks with CPU feature checks in IR validation test. > - Remove Saturating IRNode patterns. > - Restrict IR validation to newly added UMin/UMax transforms. > - Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8338201 > - Prod build fix > - Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8338201 > - New IR tests + additional IR transformations > - ... and 27 more: https://git.openjdk.org/jdk/compare/158b93d1...0e10139c This caused a regression: [JDK-8343246](https://bugs.openjdk.org/browse/JDK-8343246) Jatin, could you please have a look? ------------- PR Comment: https://git.openjdk.org/jdk/pull/20507#issuecomment-2449161173
