On Tue, 8 Oct 2024 20:31:04 GMT, Naoto Sato <na...@openjdk.org> wrote:
> I am not sure allowing null for those setters just because not to throw > exceptions in equals() is the right solutoin. The distinction is made purely > based on the existing behavior (which I believe is just an overlook in the > first place). My preference is to null check in the setter methods, as there > is no reason to set them null. That is just a misuse of the setters. OK, if we are fine with the behavioral change, I will change the direction of this PR to instead be an update to the setters to ensure NPEs for the offending methods. Will file a CSR. ------------- PR Comment: https://git.openjdk.org/jdk/pull/21315#issuecomment-2400795454